Add spatio_temporal_voxel_layer (Nav2 layer)#157
Open
onkoe wants to merge 2 commits intoRoboStack:mainfrom
Open
Add spatio_temporal_voxel_layer (Nav2 layer)#157onkoe wants to merge 2 commits intoRoboStack:mainfrom
spatio_temporal_voxel_layer (Nav2 layer)#157onkoe wants to merge 2 commits intoRoboStack:mainfrom
Conversation
this was already added in the Humble repo: RoboStack/ros-humble#275 by the way, this package is called `ros-humble-spatio-temporal-voxel-layer` for Humble, so the new package name would be `ros-jazzy-spatio-temporal-voxel-layer`
Contributor
|
Hi @onkoe - thanks for this! It seems like the patch doesn't apply cleanly on linux for some reason. Can you please take a look? |
Contributor
|
ros-jazzy/pkg_additional_info.yaml Lines 111 to 112 in 934d6ab just remove openvdb patch because it is already de-vendored. |
wep21
reviewed
Feb 8, 2026
Comment on lines
+249
to
+250
| openvdb_vendor: | ||
| add_host: ["openvdb"] |
Contributor
There was a problem hiding this comment.
Suggested change
| openvdb_vendor: | |
| add_host: ["openvdb"] |
Member
There was a problem hiding this comment.
To do this, I guess we also need to add the libopenvdb-dev key in robostack.yml ?
Member
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
You're right. Thank you for pointing it out.
Contributor
|
@onkoe @wep21 - do you want to address @traversaro's comment so we can merge here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was already added in the Humble repo! See: RoboStack/ros-humble#275
Just found out you want this when using LiDAR, so I'd like to get this merged ASAP! Please let me know if you'd like any changes; however, I basically just copied that other PR.
Sadly, the upstream fix (which includes the patches in here) is only merged for the Kilted releases of the package: 2.6.0 and higher. See: SteveMacenski/spatio_temporal_voxel_layer#325