Refactor AWS session creation with profile support#53
Open
alberttwong wants to merge 3 commits intoRedislabs-Solution-Architects:mainfrom
Open
Refactor AWS session creation with profile support#53alberttwong wants to merge 3 commits intoRedislabs-Solution-Architects:mainfrom
alberttwong wants to merge 3 commits intoRedislabs-Solution-Architects:mainfrom
Conversation
alberttwong
requested review from
ajGingrich,
kurtfm,
mar1boroman,
sagile and
thomasefthymiou78
as code owners
Refactor AWS session creation with profile support
Add mock STS client to test cases for AWS services.
ajGingrich
reviewed
Apr 2, 2026
| identity = sts.get_caller_identity() | ||
| print(f"Using AWS identity: {identity['Arn']}") | ||
|
|
||
| print(f"Requesting information for the {section} nodes") |
Collaborator
There was a problem hiding this comment.
this is duplicated down below
ajGingrich
reviewed
Apr 2, 2026
| aws_session_token = None | ||
|
|
||
| # Create session with credentials | ||
| session = boto3.Session( |
Collaborator
There was a problem hiding this comment.
won't this remove the ability to authenticate using access keys directly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.