Allow non-UTF-8 strings in event names and ACL categories - #475
Merged
Conversation
memark
changed the title
oshadmi
reviewed
Jul 15, 2026
oshadmi
reviewed
Jul 15, 2026
Contributor
There was a problem hiding this comment.
Can add a test with invalid UTF-8?
Collaborator
Author
There was a problem hiding this comment.
Added a test for an invalid UTF-8 event name.
The ACL category currently cannot be invalid UTF-8 (but I still think the change is reasonable), so no test for that.
memark
changed the title
memark
changed the title
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WU5uyqsgepVDMSURWUvwz
oshadmi
reviewed
Jul 15, 2026
oshadmi
previously approved these changes
Jul 15, 2026
oshadmi
approved these changes
Jul 15, 2026
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two places in macros.rs called
CStr::to_str().unwrap()which would panic for invalid UTF-8. Changed both places to callCStr::to_string_lossy()instead.NB: For invalid UTF-8 this call will allocate memory.
Solves #472.