feat(jump-links): add <rh-jump-links>#2194
Merged
bennypowers merged 56 commits intostaging/cubonefrom Apr 7, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 00bb30e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bennypowers
force-pushed
the
feat/jump-links
branch
from
d2197e6 to
f221d17
Compare
Contributor
|
Size Change: +5.83 kB (+2.57%) Total Size: 232 kB
ℹ️ View Unchanged
|
5 tasks
bennypowers
force-pushed
the
feat/jump-links
branch
from
ce35177 to
704bb82
Compare
bennypowers
commented
Mar 24, 2025
bennypowers
force-pushed
the
feat/jump-links
branch
from
ab9f15c to
dd5abd3
Compare
bennypowers
force-pushed
the
feat/jump-links
branch
from
d1d943c to
e64f203
Compare
Member
Author
|
attempt number one at responsive disclosure unwrapping: rh-disclosure.css :host {
border: var(--rh-border-width-sm, 1px) solid var(--rh-color-border-subtle);
display: block;
font-family: var(--rh-font-family-body-text);
container-name: disclosure;
@container disclosure style(--display: contents) {
border: none;
}
}
details,
summary,
#details-content {
@container disclosure style(--display: contents) {
display: contents;
}
&::details-content {
display: block;
}
}
rh-icon {
@container disclosure style(--display: contents) {
display: none;
}
}jump-links-responsive-pattern.css @media (width >= /*--rh-media-md*/ 992px) {
display: grid;
grid-template-columns: auto 1fr;
gap: var(--rh-space-lg);
align-items: start;
& rh-disclosure {
--display: contents;
position: sticky;
top: 0;
}
} |
NB: revert this, merge pfe changes, release pfe and update here before merging
make the main demo super simple, add a contentful demo
use #2272 instead
zeroedin
approved these changes
Apr 7, 2025
Collaborator
zeroedin
left a comment
zeroedin
left a comment
There was a problem hiding this comment.
Links Graciously Trigger Movement
adamjohnson
approved these changes
Apr 7, 2025
Collaborator
adamjohnson
left a comment
adamjohnson
left a comment
There was a problem hiding this comment.
Links Gently Track Movement
github-project-automation
bot
moved this from Review 🔍
to Done ☑️
in Red Hat Design System
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
<rh-jump-links>with rudimentary docsTesting Instructions
<rh-jump-links>docs, see demos and open each in new tab