Merged
Conversation
Contributor
makomweb
commented
Jun 21, 2025
makomweb
commented
- uses Rector to bring the code base up to being PHP 8.4 compliant
- fixes a bug with an optional default scheduler being null
Contributor
|
Can you double check the following please?
|
Contributor
Author
|
@bartvanhoutte What do I have to do in order to see this deprecation message? |
|
What is the status of this PR ? do you need a help ? |
Contributor
Author
|
@daifma Yes, I have no idea what is missing to get this merged. All kinds of advice would be awesome. |
mbonneau
reviewed
Oct 27, 2025
| } | ||
|
|
||
| public function setDisposable(DisposableInterface $disposable = null) | ||
| public function setDisposable(?DisposableInterface $disposable = null) |
Member
There was a problem hiding this comment.
Nullable parameter type is not supported in 7.0.0 - we should bump the composer.json php version up to 7.1 or higher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.