Skip to content

Avoid using structure() in tests#7814

Open
MichaelChirico wants to merge 15 commits into
masterfrom
structure
Open

Avoid using structure() in tests#7814
MichaelChirico wants to merge 15 commits into
masterfrom
structure

Conversation

@MichaelChirico

Copy link
Copy Markdown
Member

Follow-up to #7813.

structure() is slow, and, as we saw there, can be a bit fragile. It's better to use the greenlit path to construct objects where possible.

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (f55ed35) to head (8102bf2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7814   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          88       88           
  Lines       17228    17234    +6     
=======================================
+ Hits        17059    17065    +6     
  Misses        169      169           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
  • HEAD=structure much slower for as.data.table.array improved in #7019
  • HEAD=structure much slower for transform improved in #5493
  • HEAD=structure slower P<0.001 for memrecycle regression fixed in #5463
    Comparison Plot

Generated via commit 8102bf2

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 6 minutes and 49 seconds
Installing different package versions 12 minutes and 7 seconds
Running and plotting the test cases 5 minutes and 31 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant