Send Authorization header on Scratch project save#1423
Open
abcampo-iry wants to merge 1 commit intomainfrom
Open
Send Authorization header on Scratch project save#1423abcampo-iry wants to merge 1 commit intomainfrom
abcampo-iry wants to merge 1 commit intomainfrom
Conversation
abcampo-iry
temporarily deployed
to
previews/1423/merge
GitHub Actions
Inactive
abcampo-iry
force-pushed
the
issues/1256-missing-bits-for-using-headers-in-ui
branch
from
5379075 to
7c06922
Compare
abcampo-iry
temporarily deployed
to
previews/1423/merge
GitHub Actions
Inactive
abcampo-iry
force-pushed
the
issues/1256-missing-bits-for-using-headers-in-ui
branch
from
7c06922 to
bec51a0
Compare
abcampo-iry
temporarily deployed
to
previews/1423/merge
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abcampo-iry
force-pushed
the
issues/1256-missing-bits-for-using-headers-in-ui
branch
from
bec51a0 to
ea95998
Compare
abcampo-iry
temporarily deployed
to
previews/1423/merge
GitHub Actions
Inactive
abcampo-iry
force-pushed
the
issues/1256-missing-bits-for-using-headers-in-ui
branch
from
ea95998 to
aa2891b
Compare
abcampo-iry
temporarily deployed
to
previews/1423/merge
GitHub Actions
Inactive
abcampo-iry
force-pushed
the
issues/1256-missing-bits-for-using-headers-in-ui
branch
from
aa2891b to
1c5d459
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to close: https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1256
Scratch project loads already use scratchFetch metadata,
but saves were still going through scratch-gui's default xhr path, so PUT/POST requests lost the Authorization header after the cookie auth removal.
Override the Scratch save path in editor-ui to use scratchFetch for create/update requests, preserving the existing request shape while applying the auth metadata on save/remix as well.