Undo the flipping of GLES viewport and scissor coordinates#497
Merged
RandyGaul merged 1 commit intoRandyGaul:masterfrom Apr 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I wrote that comment about flipping ("Flip the scissor rect vertically since OpenGL..."), I was either confused or was experimenting with different render flipping methods to deal with the coordinate differences with Vulkan/SDL_GPU.
In the end it was never needed when flipping is handled by SPIRV-Tools at shader level but I forgot to remove the comment and the rect can just be passed verbatim.
This can be confirmed by running the scissor sample with both the SDL_GPU and GLES renderer.