🚑️ Fix #4938 - Theme persistence #4939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting a new theme, these three functions need to run in sequence.
AppDefaults.shared.currentThemeName = newValue
updateThemeNames()
updateCurrentTheme()
Within updateThemeNames() there is a `Task { @mainactor in }` that allows `updateCurrentTheme()` to complete before `updateThemeNames()`. In this scenario, when `updateCurrentTheme() is run the app hasnt got an itinerary of installed themes, so it sets the current them back to Default.
Removing the `Task` fixes the persistence issue.
brentsimmons
approved these changes
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting a new theme, these three functions need to run in sequence.
Within
updateThemeNames()there is aTask { @MainActor in }that allowsupdateCurrentTheme()to complete beforeupdateThemeNames()returns. In this scenario, when `updateCurrentTheme() is run the app hasn't got an itinerary of installed themes, so it sets the current them back to Default.Removing the
Taskfixes the persistence issue.