Draft
Conversation
Member
? |
Member
Author
|
@nirs it is still a draft. I created it to work with @raghavendra-talur |
Member
|
If we move controller type to env variable, we need to change also ramenctl - it expects to find the controller type in the config and will fail cluster validate without a controller type. ramenctl can extract the controller type from deployment but it is harder than using the config, and it is not consistent when some values come from the config and some from the environment. We need a good reason to split configuration in env and config. |
Signed-off-by: Elena Gershkovich <[email protected]>
Signed-off-by: Elena Gershkovich <[email protected]>
… from file Signed-off-by: Elena Gershkovich <[email protected]>
Signed-off-by: Elena Gershkovich <[email protected]>
ELENAGER
force-pushed
the
DFBUGS-440
branch
2 times, most recently
from
5c25ad3 to
56a1ba4
Compare
Signed-off-by: Elena Gershkovich <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.