Open
Conversation
- Implement S3 path contents checking in isPVAndPVCDataInS3 and isVGRAndVGRCDataInS3 - Detect when S3 profile changes by checking for missing data in stores - Trigger re-upload when S3 data is missing, bypassing ClusterDataProtected checks - Extract common S3 data checking logic into generic helper functions - Add comprehensive unit tests for PV/PVC and VGR/VGRC profile change detection - Fix all linting errors: blank lines before returns, error handling in tests - Reduce code duplication and cognitive complexity Signed-off-by: raaizik <[email protected]>
raaizik
force-pushed
the
handle-s3-profile-changes
branch
from
0cb45f8 to
dd1811b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement detection of S3 profile changes and automatic data re-upload when S3 data becomes unavailable.
By checking directly the S3 path's contents, the system now detects when expected PV/PVC or VGR/VGRC data is missing from S3 stores. When S3 data is absent, the system triggers automatic re-upload regardless of the ClusterDataProtected condition state, ensuring data consistency when S3 profiles are reconfigured or storage is reset.
Changes