Avoid PVC list loop for VGS class resolution#2375
Open
ELENAGER wants to merge 1 commit intoRamenDR:mainfrom
Open
Avoid PVC list loop for VGS class resolution#2375ELENAGER wants to merge 1 commit intoRamenDR:mainfrom
ELENAGER wants to merge 1 commit intoRamenDR:mainfrom
Conversation
ELENAGER
force-pushed
the
DFBUGS-4972
branch
3 times, most recently
from
69d5c96 to
594a416
Compare
ELENAGER
force-pushed
the
DFBUGS-4972
branch
3 times, most recently
from
d07d85c to
6269181
Compare
ELENAGER
changed the title
ELENAGER
force-pushed
the
DFBUGS-4972
branch
2 times, most recently
from
7db6a7b to
2cb9882
Compare
Improvement: pass an additional parameter (the storage class name) to GetVolumeGroupSnapshotClassFromPVCsStorageClass to make it more efficient. With this parameter, we can avoid listing PVCs by label and iterating through them to determine the storage class provider name. Signed-off-by: Elena Gershkovich <[email protected]>
ELENAGER
force-pushed
the
DFBUGS-4972
branch
from
2cb9882 to
e2d314e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement: pass an additional parameter (the storage class name) to GetVolumeGroupSnapshotClassFromPVCsStorageClass to make it more efficient. With this parameter, we can avoid listing PVCs by label and iterating through them to determine the storage class provider name.