Open
Conversation
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
raghavendra-talur
requested review from
BenamarMk and
ShyamsundarR
as code owners
raghavendra-talur
requested review from
ELENAGER,
abhijeet219,
am-agrawa,
asn1809,
nirs,
parikshithb,
pruthvitd,
raaizik and
rakeshgm
ELENAGER
approved these changes
Dec 17, 2025
Member
ELENAGER
left a comment
ELENAGER
left a comment
There was a problem hiding this comment.
Looks good, only lint error must be fixed
This helps the log reader to understand that the next log line failure to get the placementRule is not a critical error. Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
raghavendra-talur
force-pushed
the
rtalur-log-enhancement-drpc
branch
from
e2b3c47 to
2c47e50
Compare
rakeshgm
approved these changes
Dec 18, 2025
parikshithb
reviewed
Dec 19, 2025
| return nil, err | ||
| } | ||
|
|
||
| placementType = "PlacementRule" |
Member
There was a problem hiding this comment.
I think the placementType assignments are swapped. This should be "Placement", since we're in the error block where PlacementRule wasn't found.
| "can't proceed. PlacementRule and Placement CR with the same name exist on the same namespace") | ||
| } | ||
|
|
||
| placementType = "Placement" |
Member
|
I already have an open PR for this purpose @raghavendra-talur #2045 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some simple log enhancements in the drpc reconcile workflow.