Removes test helper constant NoS3StoreAvailable#2329
Open
raaizik wants to merge 1 commit intoRamenDR:mainfrom
Open
Removes test helper constant NoS3StoreAvailable#2329raaizik wants to merge 1 commit intoRamenDR:mainfrom
raaizik wants to merge 1 commit intoRamenDR:mainfrom
Conversation
removes test helper constant NoS3StoreAvailable
Removes the NoS3StoreAvailable constant ("NoS3") that was marked with
FIXME as a test helper. Replace all usages with empty string checks
and refactor S3Profiles slice handling to filter empty strings upfront
before processing.
Changes:
- Remove NoS3StoreAvailable constant from ramenconfig.go
- Replace constant comparisons with empty string checks for single
S3ProfileName fields
- Refactor S3Profiles slice handling to filter empty strings upfront
instead of checking during iteration
- Remove skipIfS3ProfileIsForTest() function as it's no longer needed
- Update test files to use empty strings instead of the constant
This improves code quality by:
- Removing test-specific constants from production code
- Using more efficient upfront filtering for slices
- Maintaining consistent behavior while simplifying the codebase
Resolves RamenDR#1710
Signed-off-by: raaizik <132667934+raaizik@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the NoS3StoreAvailable constant ("NoS3") that was marked with FIXME as a test helper. Replace all usages with empty string checks and refactor S3Profiles slice handling to filter empty strings upfront before processing.
Changes
skipIfS3ProfileIsForTest()function as it's no longer neededThis improves code quality by:
Resolves #1710