Conversation
|
The changes seem sane to me 😄
This is correct, we should probably issue a reset if this setting is changed, since we dont have a known-good-and-safe way to reset the BLE stack correctly. Happy if you want to throw that in this pr. Any chance you can run the re-build for the docs to update them (or manually patch, your call) as its the only CI that's unhappy. |
|
Thanks for the heads up about the CI, that should be fixed now. I also added an extra commit to reboot the iron when bluetooth is toggled. I tripped on the "hold the |
|
After a little too much fiddling with Claude, I tried the most basic thing: have a button just call |
|
Tried a number of things, the double reboot problem seems to depend on the power supply:
Also, with Claude we tried a number of things, nothing worked. This is the last one just in case (not working, of course): void reboot() {
WDT_Disable();
hal_por_reset();
}In short, looks like a power supply against recommendations does not work properly, which is mildly surprising (a little bit still, since the recommendations are about soldering, not rebooting 🤷). WDYT? |
|
Ahhh, most likely your using a power supply that uses PPS or EPS. For these supplies you need to keep sending a keep-alive packet to keep the power on. If that stops, after a timeout it will reboot you back to 5V (and then you can negotiate up again). You wont reallllly be able to get around the double reboot on those supplies, since we dont have a good means to keep the state of the PD stack over restarts. I wouldn't bother turning off the WDT or anything, just do a reboot and if we double reboot so-be-it. imho :) |
I agree. PR updated to fix CI failures 🚀 |
Read-only ble mode for Pinecil v2. Fixes #2203.
Currently, if Bluetooth is activated, clients can change all settings and temperature.
With read-only, clients trying any write action will receive an error.
Disclaimer: this has been done mostly by Claude Opus 4.6. That said, being a developer myself (sadly not C++), I reviewed the code and it looks ok. I deployed it on my Pinecil and it smells ok as well.
Also, poking around I found another possibly interesting change. Currently, if bluetooth is enabled, in order to disable it one should change it in settings, exit the menus, then unplug and replug the iron, which is not really "intuitive" (one would think that as most settings this would apply immediately).