Update formatting.yml for Rocprofiler-sdk #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed runners to ubuntu-latest instead of AMD-ROCm-Internal-dev1
amd-hsivasun
changed the title
systems-assistant bot
pushed a commit
that referenced
this pull request
Aug 5, 2025
Set execute permission for HSA allocated memory We need execute permission for HSA memory (req for IB buffers). Enforcement is upcoming which will break counter collection (see ticket). Change-Id: Id939bbdd8686915407bc60d0dfcd5110b0e91e90 Co-authored-by: Benjamin Welton <[email protected]> Co-authored-by: Bhardwaj, Gopesh <[email protected]>
systems-assistant bot
pushed a commit
that referenced
this pull request
Aug 5, 2025
* General logging updates
* ROCm 6.1.x fatal defect: unconditional abort if tool found but rocprofiler-sdk missing
- Adding rocprofiler-sdk support breaks backwards compatibility in ROCm 6.1.x because `rocprofiler_configure` symbol triggers looking for rocprofiler-sdk library (which was not released until ROCm 6.2)
- Bump version to 0.5.0
* revert to using fatal error
* Include header updates
* Fix CodeQL suggestions
* CMake and CI updates
- minimum cmake version is 3.22.0
- added requirements.txt
- improved rocprofiler_register_{formatting,linting}.cmake
* Disable deprecated declarations warnings
* Use "overwrite" instead of "override"
- override is a keyword in C++
* Disable REQUIRED for formatting and linting when BUILD_DEVELOPER=ON
---------
Co-authored-by: Jonathan R. Madsen <[email protected]>
systems-assistant bot
pushed a commit
that referenced
this pull request
Aug 5, 2025
* Obey CMAKE_BUILD_TYPE Obey CMAKE_BUILD_TYPE when it is passed on the command line. Previous behavior remains: Debug by default ROCRTST_BLD_TYPE can set build type * External CI: change trigger from amd-master to amd-mainline * Added gfx94x and gfx11xx IDs to enumerator (#5) * Use idomatic approach to extending CMAKE_MODULE_PATH. (#7) There are many reasons why there may already be a CMAKE_MODULE_PATH defined. The idiomatic way to extend it in a project is via list(APPEND). ROCm/rocminfo#97 submitted by @stellaraccident Co-authored-by: Stella Laurenzo <[email protected]> * Added release trigger for further releases * Fix for typo in ISA_TO_ID table (#6) Change-Id: Id0720988fb01079a3ca6f3287dc743d93db4fd0f * Remove WSL checks for displaying UUID and BDFID Signed-off-by: lyndonli <[email protected]> * Added KWS check for amd-mainline (#9) --------- Signed-off-by: lyndonli <[email protected]> Co-authored-by: benrichard-amd <[email protected]> Co-authored-by: Su, Daniel <[email protected]> Co-authored-by: Stella Laurenzo <[email protected]> Co-authored-by: Mallya, Ameya Keshava <[email protected]> Co-authored-by: Yat Sin, David <[email protected]> Co-authored-by: lyndonli <[email protected]>
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 5, 2025
* General logging updates
* ROCm 6.1.x fatal defect: unconditional abort if tool found but rocprofiler-sdk missing
- Adding rocprofiler-sdk support breaks backwards compatibility in ROCm 6.1.x because `rocprofiler_configure` symbol triggers looking for rocprofiler-sdk library (which was not released until ROCm 6.2)
- Bump version to 0.5.0
* revert to using fatal error
* Include header updates
* Fix CodeQL suggestions
* CMake and CI updates
- minimum cmake version is 3.22.0
- added requirements.txt
- improved rocprofiler_register_{formatting,linting}.cmake
* Disable deprecated declarations warnings
* Use "overwrite" instead of "override"
- override is a keyword in C++
* Disable REQUIRED for formatting and linting when BUILD_DEVELOPER=ON
---------
Co-authored-by: Jonathan R. Madsen <[email protected]>
[ROCm/rocprofiler-register commit: cb1b430]
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 5, 2025
Set execute permission for HSA allocated memory We need execute permission for HSA memory (req for IB buffers). Enforcement is upcoming which will break counter collection (see ticket). Change-Id: Id939bbdd8686915407bc60d0dfcd5110b0e91e90 Co-authored-by: Benjamin Welton <[email protected]> Co-authored-by: Bhardwaj, Gopesh <[email protected]> [ROCm/rocprofiler commit: 6cc5501]
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 11, 2025
There are many reasons why there may already be a CMAKE_MODULE_PATH defined. The idiomatic way to extend it in a project is via list(APPEND). ROCm/rocminfo#97 submitted by @stellaraccident Co-authored-by: Stella Laurenzo <[email protected]> [ROCm/rocminfo commit: 8503ec3]
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 11, 2025
* Obey CMAKE_BUILD_TYPE Obey CMAKE_BUILD_TYPE when it is passed on the command line. Previous behavior remains: Debug by default ROCRTST_BLD_TYPE can set build type * External CI: change trigger from amd-master to amd-mainline * Added gfx94x and gfx11xx IDs to enumerator (#5) * Use idomatic approach to extending CMAKE_MODULE_PATH. (#7) There are many reasons why there may already be a CMAKE_MODULE_PATH defined. The idiomatic way to extend it in a project is via list(APPEND). ROCm/rocminfo#97 submitted by @stellaraccident Co-authored-by: Stella Laurenzo <[email protected]> * Added release trigger for further releases * Fix for typo in ISA_TO_ID table (#6) Change-Id: Id0720988fb01079a3ca6f3287dc743d93db4fd0f * Remove WSL checks for displaying UUID and BDFID Signed-off-by: lyndonli <[email protected]> * Added KWS check for amd-mainline (#9) --------- Signed-off-by: lyndonli <[email protected]> Co-authored-by: benrichard-amd <[email protected]> Co-authored-by: Su, Daniel <[email protected]> Co-authored-by: Stella Laurenzo <[email protected]> Co-authored-by: Mallya, Ameya Keshava <[email protected]> Co-authored-by: Yat Sin, David <[email protected]> Co-authored-by: lyndonli <[email protected]> [ROCm/rocminfo commit: aec5d6f]
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 18, 2025
[ROCm/hipother commit: 3eb783e]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed runners to ubuntu-latest instead of AMD-ROCm-Internal-dev1