[rocjitsu] Add CI workflow (TheRock tarball approach) - #6499
Closed
newling wants to merge 6 commits into
Closed
Conversation
github-actions
Bot
added
the
github actions
newling
force-pushed
the
rocjitsu-ci-therock
branch
2 times, most recently
from
May 27, 2026 23:29
7086151 to
12b2675
Compare
newling
commented
May 27, 2026
newling
commented
May 27, 2026
3 tasks
3 tasks
newling
changed the title
newling
force-pushed
the
rocjitsu-ci-therock
branch
from
May 27, 2026 23:58
12b2675 to
6b8cac6
Compare
newling
marked this pull request as ready for review
May 27, 2026 23:59
atgutier
reviewed
May 28, 2026
kuhar
reviewed
May 28, 2026
newling
force-pushed
the
rocjitsu-ci-therock
branch
from
May 28, 2026 17:21
6b8cac6 to
1a72c76
Compare
kuhar
approved these changes
May 29, 2026
newling
force-pushed
the
rocjitsu-ci-therock
branch
from
May 29, 2026 05:35
ff7120b to
0d5ef9c
Compare
atgutier
approved these changes
May 29, 2026
Contributor
|
@ROCm/rocm-systems-reviewers can you give this a review? |
newling
force-pushed
the
rocjitsu-ci-therock
branch
from
May 29, 2026 23:48
78531a3 to
468f5f1
Compare
Contributor
|
I'm curious what this does that isn't already handled with the rock cli. already configured the build matrix to only build emulation stuff iff emulation stuff is modified. also, I got us some compute assigned as well for therock ci, so we will be able to run the dbt tests as well using therock ci. give us a lot of benefits using their infra. |
Contributor
Author
Well, there is currently no testing of rocjitsu in CI. i.e. no unit tests of rocjitsu are run on PRs / merges. This is very bad. This PR aims to remedy that. |
Contributor
we just got compute to run the tests in therock, so let's run the tests properly in therock. |
Contributor
Author
|
Just to keep reviewers updated, @amd-arosa is planning on creating a version of this PR that runs in TheRock CI |
Before this PR, the TheRock CI builds rocjitsu (as part of THEROCK_ENABLE_EMULATION) but does not run its tests — rocjitsu is not in repos-config.json. The only rocjitsu-specific CI is pre-commit formatting. After this PR, every PR touching emulation/rocjitsu/ gets a dedicated job that builds rocjitsu and runs its full ctest suite (~450 tests), including HIP integration tests (memcpy, vector_add, matmul). No GPU hardware needed — tests run on the built-in CPU emulator. ROCm installed via TheRock nightly tarball. RocminfoTest excluded (requires /dev/kfd, unavailable on CI). Related PRs: - ROCm#6448: alternative using ROCm apt packages - ROCm#6479: alternative using ROCm pip packages
newling
force-pushed
the
rocjitsu-ci-therock
branch
from
June 5, 2026 18:10
92c4690 to
4fd45ce
Compare
Contributor
Author
|
We now have rocjitsu-test-corpus which largely supersedes this PR now. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workflow that