[rocDecode][Samples] - Fix rocdecDecode sample filesystem issue on SLES #3028
+16
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a filesystem compatibility issue in the rocdecDecode sample on SLES by adding fallback support for std::experimental::filesystem when std::filesystem is unavailable.
Changes:
- Adds conditional compilation to detect and use
std::filesystem(C++17) or fall back tostd::experimental::filesystem - Introduces a
fsnamespace alias to abstract filesystem implementation differences - Links against
stdc++fslibrary in CMake to support experimental filesystem - Removes color formatting from CMake messages
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/rocdecode/samples/rocdecDecode/rocdecdecode.cpp | Adds conditional filesystem header inclusion with namespace aliasing and updates filesystem API calls to use the fs alias |
| projects/rocdecode/samples/rocdecDecode/CMakeLists.txt | Adds stdc++fs library linking and simplifies CMake message formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rrawther
reviewed
Feb 3, 2026
| bool b_sort_filenames = false; | ||
| if (std::filesystem::is_directory(input_file_path)) { | ||
| for (const auto& entry : std::filesystem::directory_iterator(input_file_path)) { | ||
| if (fs::is_directory(input_file_path)) { |
Contributor
There was a problem hiding this comment.
Why is this changed from std::filesystem?
Member
Author
There was a problem hiding this comment.
@rrawther it is changed to support both std::filesystem and std::experimental::filesystem (please see below)
#if __cplusplus >= 201703L && __has_include(<filesystem>)Expand commentComment on line R28Resolved
#include <filesystem>
namespace fs = std::filesystem;
#else
#include <experimental/filesystem>
namespace fs = std::experimental::filesystem;
#endif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It fixes rocdecDecode sample filesystem issue on SLES
Technical Details
It introduces a check to verify the existence of std::filesystem; if it is unavailable, the code falls back to using std::experimental::filesystem.
JIRA ID
Test Plan
rocDecode CTEST
Test Result
rocDecode CTEST should pass.
Submission Checklist