[rocprofiler-compute] [Documentation] Add metric descriptions for missing gfx942 metrics#3027
Open
vedithal-amd wants to merge 1 commit intodevelopfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds documentation for 10 previously undocumented metrics specific to the gfx942 (MI300) architecture, improving the completeness of profiling documentation for this hardware generation.
Changes:
- Added metric descriptions for gfx942-specific hardware counters across memory, compute, and cache subsystems
- Updated configuration hash database to reflect the documentation changes
- Added changelog entry documenting the metric description additions
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gfx942_metrics_description.yaml | Added 5 RST-formatted metric descriptions for F8 MFMA ops, cache hit rates, atomic requests, and 128B reads |
| .config_hashes.json | Updated configuration file hashes for modified analysis config files |
| 1700_l2_cache.yaml | Added description for L2 128B read requests metric |
| 1500_address_processing_unit_and_data_return_path_ta_td.yaml | Added descriptions for 3 sequencer stall metrics in the address processing unit |
| 1100_compute_units_compute_pipeline.yaml | Added descriptions for F8 MFMA floating-point operations metrics |
| 0300_memory_chart.yaml | Added description for scalar L1D cache latency metric |
| CHANGELOG.md | Documented the addition of missing gfx942 metric descriptions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vedithal-amd
force-pushed
the
users/vedithal/rocprofiler-compute-fix-metrics-description
branch
from
07817fc to
87204a2
Compare
vedithal-amd
force-pushed
the
users/vedithal/rocprofiler-compute-fix-metrics-description
branch
from
87204a2 to
5358ab3
Compare
vedithal-amd
force-pushed
the
users/vedithal/rocprofiler-compute-mi300-metric-descriptions
branch
from
659bd27 to
04590cd
Compare
Base automatically changed from
users/vedithal/rocprofiler-compute-fix-metrics-description
to
develop
February 3, 2026 14:40
Add metric descriptions for gfx942 metrics that were previously missing descriptions across multiple hardware blocks: - Memory Chart (sL1D): 1 metric - Compute Pipeline (MFMA): 2 metrics - Address Processing Unit (TA): 3 metrics - L2 Cache (Fabric Interface): 1 metric Additionally, add RST descriptions in per-arch yaml for: - Speed-of-Light panels: 3 metrics - Cache access metrics: 2 metrics Update config hashes for consistency verification.
vedithal-amd
force-pushed
the
users/vedithal/rocprofiler-compute-mi300-metric-descriptions
branch
from
04590cd to
f8f8c86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds metric descriptions for 10 gfx942 (MI300) metrics that were previously missing descriptions across the following hardware blocks:
These descriptions provide essential context for users profiling and analyzing performance on gfx942 architecture (MI300 series), including details on hardware counters, stall conditions, and architectural behavior specific to MI300's advanced features like F8 MFMA operations.
Technical Details
This PR uses material such as:
counter_defs.yamlAforementioned information was used to derive accurate metric descriptions following established conventions
Changes:
gfx942_metrics_description.yaml)src/utils/.config_hashes.json) for configuration integrity verification:ref:cross-referencesJIRA ID
ROCM-1126
AIPROFCOMP-9
Test Plan
Test Result
Submission Checklist