rocr: Fix metadata sharing issue in ipc import/export #3022
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manocharahul
requested review from
cfreeamd,
dayatsin-amd and
kentrussell
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a metadata sharing issue in the IPC import/export functionality of the ROCR runtime. The problem was identified through PSDB test failures and involves correcting the order of metadata handling during buffer import operations.
Changes:
- Moved metadata assignment from after the ImportMemory call to before it, ensuring proper metadata propagation during IPC operations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gandryey
approved these changes
Feb 2, 2026
dayatsin-amd
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix PSDB test failures in IPC import/export due to previous commit
#1912
Technical Details
JIRA ID
Test Plan
Test Result
Submission Checklist