Add extra check on refCount for memory object in hipMemAddressFree #3015
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Removal of a memory object from the memory object maps occurs in the memory destructor. As such, at the end of hipMemAddressFree we need to be certain that we enter the memory destructor so as to clean the memory object maps.
Technical Details
Add a device synchronize and a check on the reference count for the memory object to ensure that we enter the memory destructor.
JIRA ID
N/A
Test Plan
Pytorch expandable segments test.
Test Result
Test is passing.
Submission Checklist