Rocprofiler-Compute Formatting Workflow #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammallya
pushed a commit
that referenced
this pull request
Aug 6, 2025
[ROCm/rocprofiler-systems commit: fb549fc]
ammallya
pushed a commit
that referenced
this pull request
Aug 6, 2025
[ROCm/rocprofiler-systems commit: 09f5ac6]
ammallya
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Adding changes to register and read symbols from the hip fat binary * adding json output for host_functions * added error handling * adding json tool support * Adding tests * formatting changes * Adding documentation * refactoring as per amd-staging * Adding intializers and changing macros * Fix page-migration background thread on fork (#31) * Fix page-migration background thread on fork After falling off main in the forked child, all the children try to join on on the parent's monitoring thread. This results in a deadlock. Parent is waiting for the child to exit, but the child is trying to join the parent's thread which is signaled from the parent's static destructors. Even with just one parent and child, due to copy-on-write semantics, a child signalling the background thread to join will still block (thread's updated state is not visible in the child). This fix creates background treads on fork per-child with a pthread_atfork handler, ensuring that each child has its own monitoring thread. * Formatting fixes * Detach page-migration background thread and update test timeout * Attach files with ctest * Update corr-id assert * Tweak on-fork, simplify background thread * Revert thread detach * Adding --collection-period feature in rocprofv3 to match v1/v2 parity (#9) * Adding Trace Period feature to rocprofv3 * Adding feature documentation * Update source/bin/rocprofv3.py Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fixing format * Moving to Collection Period and changing the input params * Format Fixes * Fixing rebasing issues * Removing atomic include from the tool * Adding more options for units, optimizing the code * Fixing rocprofv3.py * Fixing time conv & adding time controlled app * Fixing format * Changing to shared memory testing methodology * use of shmem use * Fix include headers for transpose-time-controlled.cpp * Format upload-image-to-github.py * Removing shmem and using only env var to dump timestamps from the tool * Tool Fixes + Test Config * Adding Tests * Fixing Review comments * Update trace period implementation * Update trace period tests * check between start and stop timestamps * Merge Fix * Update validate.py * Improve safety of rocprofiler_stop_context after finalization * Pass context id to collection_period_cntrl by value * Adding 20 us error margin * Ensure log level for collection-period test is not more than warning --------- Co-authored-by: Ammar ELWazir <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jonathan R. Madsen <[email protected]> * Update lib/rocprofiler-sdk/code_object/hip/code_object.* - move error code check macros to implementation - fix macros which check error code - use constexpr values instead of #define * Update lib/rocprofiler-sdk/code_object/hip/code_object.* - debugging for error that cannot be locally reproduced * Update lib/rocprofiler-sdk/code_object/hip/code_object.* - improve error handling and logging * Update lib/rocprofiler-sdk/code_object/hip/code_object.* - tweak to non-fatal logging messages * Update lib/rocprofiler-sdk/code_object/hip/code_object.* - cleanup of logging messages * Update host kernel symbol register data fields * Update source/lib/rocprofiler-sdk/code_object/hip/code_object.hpp --------- Co-authored-by: Madsen, Jonathan <[email protected]> Co-authored-by: Kuricheti, Mythreya <[email protected]> Co-authored-by: Elwazir, Ammar <[email protected]> Co-authored-by: Ammar ELWazir <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jonathan R. Madsen <[email protected]> [ROCm/rocprofiler-sdk commit: 78d8f4b]
systems-assistant bot
pushed a commit
that referenced
this pull request
Aug 10, 2025
…er (#18) Change-Id: Ic3f54b0f5bfee8565a8bbb6218fb0ccdb900c9ea
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 18, 2025
[ROCm/hipother commit: 1992d81]
ammallya
pushed a commit
that referenced
this pull request
Nov 17, 2025
ammallya
pushed a commit
that referenced
this pull request
Nov 18, 2025
) [ROCm/amdsmi commit: 23a21ea]
ammallya
pushed a commit
that referenced
this pull request
Nov 21, 2025
) [ROCm/amdsmi commit: 23a21ea]
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
Commented function that fails functional tests
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
IPC backend [ROCm/rocshmem commit: 73365cf]
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
Commented function that fails functional tests [ROCm/rocshmem commit: 3995f11]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.