Skip to content

Conversation

@sundar-pds
Copy link
Collaborator

No description provided.

@gaoikawa gaoikawa requested review from Copilot and yuva29 January 17, 2026 00:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces the "Open Source Network Operator," implementing an AMD-specific host-device CNI plugin that manages network interfaces for AMD hardware. The operator enables dynamic IP address management and network configuration for containerized workloads.

Changes:

  • Added AMD host-device CNI plugin with IP mapping and interface configuration capabilities
  • Integrated KMM (Kernel Module Management) tolerations and upgrade timeout features
  • Added comprehensive build infrastructure including Dockerfiles, Makefiles, and helm charts

Reviewed changes

Copilot reviewed 16 out of 737 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
cni/plugins/amd-host-device/utils.go Core utility functions for interface-IP mapping persistence and network configuration
cni/plugins/amd-host-device/main.go CNI plugin main logic implementing ADD, DEL, CHECK, and STATUS operations
cni/plugins/amd-host-device/go.mod Go module dependencies for the CNI plugin
cni/plugins/amd-host-device/exec.go Plugin execution wrapper for invoking host-device CNI
cni/plugins/amd-host-device/constants.go Configuration constants for the CNI plugin
cni/build/entrypoint.sh Container entrypoint script for CNI binary deployment
cni/build/Dockerfile Multi-stage Dockerfile for CNI plugin container
cmd/main.go Network operator main entry point with controller initialization
api/v1alpha1/zz_generated.deepcopy.go Auto-generated deep copy functions for tolerations
api/v1alpha1/networkconfig_types.go API type definitions with new driver tolerations and upgrade timeout state
api/.job.yml Removed CI job configuration file
PROJECT Kubebuilder project configuration
Makefile Comprehensive build and deployment automation
Dockerfile.build Development environment container build
Dockerfile Production operator container build
.gitmodules Git submodule configuration for common-infra-operator

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yuva . this file is present in ROCm/network-operator today.
As part of this PR's first commit , i have already removed this file.

Copy link
Collaborator

@yuva29 yuva29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants