[COMGR] Add missing vectorization flags#3450
Open
MrSidims wants to merge 1 commit into
Open
Conversation
They are currently being filtered out. They shouldn't - they present in llvm.cmdline.
MrSidims
force-pushed
the
vectorization-flags
branch
from
July 17, 2026 18:35
33e2f66 to
db0e2ae
Compare
Author
|
Fun fact: the issue was observed while exploring why some benchmarks are having better performance when compiled to SPIR-V. Trivial sample would be rocm-examples/convolution, which runs 20% faster if compiled to SPIR-V. This patch "fixes" it, so now AMDGPU and SPIR-V paths would be on par. Performance will be restored (and improved) on AMDGPU when/if llvm#210399 (or similar fix) is merged. |
maarquitos14
approved these changes
Jul 17, 2026
maarquitos14
left a comment
maarquitos14
left a comment
There was a problem hiding this comment.
LGTM. I wonder if there's any test that we should update/add for this.
idubinov
approved these changes
Jul 20, 2026
idubinov
left a comment
idubinov
left a comment
There was a problem hiding this comment.
LGTM.
There is TODO about all -cc1 flags. Does the current list cover all flags or TODO still actual?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are currently being filtered out. They shouldn't - they present in llvm.cmdline.