comgr: gfx1250 hotswap WMMA VGPR-MSB split (fail-closed) review#3415
Draft
YashDeshpande25 wants to merge 4 commits into
Draft
comgr: gfx1250 hotswap WMMA VGPR-MSB split (fail-closed) review#3415YashDeshpande25 wants to merge 4 commits into
YashDeshpande25 wants to merge 4 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Spell out iterator types instead of auto in the WMMA hazard and split passes, and inline the single-caller updateWmmaHazardDeficit helper per the Comgr no-auto and over-decomposition conventions. No functional change; the 33 WMMA lit tests still pass. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens the gfx1250 B0→A0 HotSwap rewriter (amd_comgr_hotswap_rewrite). Headline fix:
a silent WMMA miscompile when an operand crosses a VGPR bank boundary — plus the change
to fail closed instead of returning SUCCESS with broken code.