[WIP] Remove padded-WMMA-operand zero fills to free the VALU for coexec#3376
Open
VigneshwarJ wants to merge 2 commits into
Open
[WIP] Remove padded-WMMA-operand zero fills to free the VALU for coexec#3376VigneshwarJ wants to merge 2 commits into
VigneshwarJ wants to merge 2 commits into
Conversation
…izer In AMDGPULateCodeGenPrepare, rewrite a shufflevector constant operand whose lanes are only poison and zero into a full zeroinitializer. For padded WMMA operands (K<instr-K data padded to the instruction K with a <poison..., 0.0...> constant), this lets ISel materialize a single uniform, dual-issuable zero instead of per-lane fills for the poison lanes, freeing the VALU to co-execute with the WMMA pipe on gfx1250. Guarded by -amdgpu-late-codegenprepare-canon-pad-zero (default on).
… copies Post-RA pass that hoists loop-invariant SGPR->VGPR V_MOVs (sole in-loop definition and preheader-clean) into the loop preheader, and deletes provably dead fills (destination fully overwritten before any use in the loop). Removes the per-iteration zero-fill moves for padded WMMA operands from the loop body. Guarded by -amdgpu-enable-sgpr-copy-opt (default on). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for PSDB test