-
Notifications
You must be signed in to change notification settings - Fork 267
refactor: remove Default scheduler implementation as it not used anymore #3542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7a7f392 to
09aa536
Compare
b9146fd to
edc6b82
Compare
edc6b82 to
2240aa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the unused "Default" scheduler implementation from the universal GEMM's memory pipeline software pipeline. The Default scheduler was likely a remnant from early development and is no longer used in the codebase.
Changes:
- Removed the Default scheduler implementation from block-level GEMM operations
- Updated the default scheduler to Intrawave in the base GEMM pipeline problem
- Removed unused template parameter and associated conditional logic from the universal GEMM kernel
- Fixed a template specialization mismatch in the AQuant pipeline (was incorrectly labeled as Interwave, now correctly Intrawave)
- Added helpful documentation comments explaining barrier instructions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
include/ck_tile/ops/gemm/block/block_universal_gemm_as_bs_cr.hpp |
Removed the BlockGemmImpl<GemmPipelineScheduler::Default> specialization (83 lines) and added clarifying comments for barrier instructions |
include/ck_tile/ops/gemm/pipeline/gemm_pipeline_problem.hpp |
Changed the default scheduler from Default to Intrawave in GemmPipelineProblemBase |
include/ck_tile/ops/gemm/kernel/universal_gemm_kernel.hpp |
Removed unused UseDefaultScheduler template parameter and associated conditional logic from RunGemm |
include/ck_tile/ops/gemm_quant/pipeline/gemm_aquant_pipeline_ag_bg_cr_mem.hpp |
Fixed template specialization from Interwave to Intrawave to match actual usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ore (#3542) * refactor: remove Default scheduler implementation as it not used anymore * refactor: remove dead code from gemm universal kernel * chore: add descriptive comments about amd intrinsic hardware sync instructions * fix: label existing memory pipeline for aquant as intrawave
Proposed changes
The universal GEMM's memory pipeline (software pipeline) has a "default" scheduler implementation for scheduling data computation instructions. This implementation is no longer used and are most likely remnants of early version of the example.
This PR removes the dead code.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered