-
Notifications
You must be signed in to change notification settings - Fork 262
[CK tests] Extend conv GPU reference #3539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johannes-graner
wants to merge
18
commits into
develop
Choose a base branch
from
jograner/extend-gpu-reference
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR extends GPU reference implementation support for convolution operations with elementwise fusion and output operations. The changes enable GPU-accelerated reference implementations for tests involving scale, bias, batchnorm, clamp, and bilinear operations across forward, backward data, and backward weight convolutions.
Key improvements:
naive_conv_fwd_gpu,naive_conv_bwd_data_gpu, andnaive_conv_bwd_weight_gputo support elementwise operations, batchnorm, clamp, scale, and bilinear fusionPerformance impact:
These improvements reduce total execution time for these tests from 1674 seconds to 859 seconds, saving approximately 14 minutes.
Checklist
clang-formaton all changed filesDiscussion
The implementation focuses on extending the GPU reference path to match the functionality available in the CPU reference path.
Additional improvement is possible by using GPU for verification and tensor initialization. This PR is already large, so those improvements are deferred.