Add rocm_smi64 to library preloads for PyTorch wheels#4440
Merged
Conversation
PyTorch upstream cherry-picked pytorch#175648 which links libtorch_hip.so against librocm_smi64.so. Without preloading this library, `import torch` fails with: ImportError: librocm_smi64.so.1: cannot open shared object file Register rocm_smi64 as a LibraryEntry in _dist_info.py and add it to LINUX_LIBRARY_PRELOADS so _rocm_init.initialize() preloads it before torch._C is imported.
1 task
Member
may need #4412 to fix that |
The dirname filter in fetch_object_names used square brackets `[...]` instead of parentheses `(...)`, creating a single-element list that is always truthy in Python (`[False]` is a non-empty list). This caused .whl files from subdirectories (e.g. test-update-deps/) to leak into the parent prefix index, generating download links that resolve to non-existent paths and return 404. Signed-off-by: Wang, Yanyao <[email protected]>
ScottTodd
reviewed
Apr 10, 2026
ScottTodd
approved these changes
Apr 10, 2026
Member
ScottTodd
left a comment
ScottTodd
left a comment
There was a problem hiding this comment.
LGTM but please revert the unrelated changes before merge
This reverts commit 7e67c8b.
ScottTodd
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
triggered https://github.com/ROCm/TheRock/actions/runs/24241363210, but the build failed with that setuptools 404 https://github.com/ROCm/TheRock/actions/runs/24247692319 issue. So now that the new build wheels are in, triggered https://github.com/ROCm/TheRock/actions/runs/24249015826 to see if we can point there. Update: BUILD SUCCEEDED
The original error snippet:
https://github.com/ROCm/TheRock/actions/runs/24242582747/job/70780812586