Add UCCL test infrastructure and CI workflow#4437
Draft
adityakankariya wants to merge 4 commits intomainfrom
Draft
Add UCCL test infrastructure and CI workflow#4437adityakankariya wants to merge 4 commits intomainfrom
adityakankariya wants to merge 4 commits intomainfrom
Conversation
…er, and CI workflow Signed-off-by: Aditya Kankariya <adkankar@amd.com>
Signed-off-by: Aditya Kankariya <adkankar@amd.com>
…est nightly Signed-off-by: Aditya Kankariya <adkankar@amd.com>
Signed-off-by: Aditya Kankariya <adkankar@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
UCCL currently has no test infrastructure within TheRock's CI. The upstream UCCL project has its own CI workflow that runs multi-node tests via SSH, but TheRock needs a single-node, container-based test suite that follows the existing patterns established by the PyTorch external build (
external-builds/pytorch/).Technical Details
Adds a two-tier test suite for UCCL, mirroring the structure in
external-builds/pytorch/:New files in
external-builds/uccl/:requirements-test.txt— test dependencies (pytest, numpy)smoke-tests/uccl_smoke_test.py— pytest smoke tests: ROCm availability, UCCL import verification, basic GPU tensor operationsrun_uccl_smoke_tests.py— smoke test runner with--amdgpu-familysupport and pytest passthroughrun_uccl_tests.py— wraps upstreamtest_intranode.pyviatorchrun --standalone, exercising EP dispatch/combine kernels on a single node with auto-detected GPU countNew CI workflow:
.github/workflows/test_uccl_wheels.yml— reusable workflow (workflow_dispatch+workflow_call) that runs smoke tests then intranode EP tests inside a container with GPU device passthrough, using the same container image and runner patterns astest_pytorch_wheels.ymlUpdated:
external-builds/uccl/README.md— added testing documentationTest Plan
uccl_repo.py checkoutsuccessfully clones UCCL sources withtest_intranode.pyat the expected pathrun_uccl_tests.py --dry-run --nproc-per-node 8produces the correcttorchruncommandTest Result
Local validation passed on all non-GPU checks. The dry-run output confirms the correct torchrun invocation:
Submission Checklist