[Enh] Support chained comparison#799
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds frontend support for Python chained comparisons (e.g. a < b < c) by lowering them into boolean operations that FlyDSL can already rewrite/lower, and adds unit coverage for both dynamic IR tracing and constexpr evaluation.
Changes:
- Add
RewriteBoolOps.visit_Comparelowering of chainedast.CompareintoBoolOp(And)to reuse existingandlowering. - Rename boolean hook dunders from
__fly_*__to__dsl_*__in both the AST rewriter andNumeric. - Add unit tests covering dynamic chained-compare lowering and constexpr chained-compare acceptance.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/unit/test_if_dispatch_paths.py | Adds a dynamic chained-compare test that verifies IR contains multiple cmpi and an andi. |
| tests/unit/test_constexpr.py | Adds a constexpr chained-compare JIT test. |
| python/flydsl/expr/numeric.py | Renames boolean hook dunders to __dsl_*__. |
| python/flydsl/compiler/ast_rewriter.py | Adds chained-compare rewrite and updates bool-op hook dispatch to __dsl_*__. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
coderfeli
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist