feat(analysis/offline):Added a filter for good events

[pgrusell]

refactor(r3bdata/tofdHitData): TofdHitData no longer inherits R3BHit, as it's not used by any other detector data. Moreover, method to get the plane id has been change from DetId to PlaneId

feat(analysis/offline): Class to filter events according to AoQ at FRS and Q at ToFD

feat(analysis/online): added method to select the charge selection algorithm

---

Checklist:

• Rebased against dev branch
• My name is in the resp. CONTRIBUTORS/AUTHORS file
• Followed the pull request guidlines and the Git workflow
• Followed the seven rules of great commit messages

[Copilot]

Pull request overview

This PR refactors the R3BTofdHitData class to no longer inherit from R3BHit and renames the method GetDetId() to GetPlaneId() for better semantic clarity. It also introduces a new event filter class R3BEventFilter for offline analysis that filters events based on FRS A/Q and ToFD charge selections.

Changes:

• Refactored R3BTofdHitData to inherit directly from TObject instead of R3BHit, with inline getters and modern C++ features
• Renamed GetDetId() to GetPlaneId() across all usages in tracking and online analysis files
• Added new R3BEventFilter class for filtering events based on FRS and ToFD criteria
• Updated header guards to use #pragma once in several files
• Code formatting improvements in R3BFiberTrackingOnlineSpectra.cxx

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
r3bdata/tofData/R3BTofdHitData.h	Complete refactoring: removed R3BHit inheritance, added inline getters, changed GetDetId to GetPlaneId, added deprecated methods for backward compatibility
r3bdata/tofData/R3BTofdHitData.cxx	Updated constructor to initialize member variables directly, removed old method implementations
tracking/R3BTrackingS515.cxx	Updated method call from GetDetId() to GetPlaneId()
tracking/R3BTrackingG249.cxx	Updated method call from GetDetId() to GetPlaneId()
tofd/online/R3BTofDOnlineSpectra.cxx	Updated method call from GetDetId() to GetPlaneId()
analysis/online/R3BTofDvsTttxOnlineSpectra.cxx	Updated method call from GetDetId() to GetPlaneId()
analysis/online/R3BFibervsTofDOnlineSpectra.cxx	Updated method call from GetDetId() to GetPlaneId()
analysis/online/R3BFiberTrackingOnlineSpectra.cxx	Updated method call from GetDetId() to GetPlaneId() and code formatting improvements
analysis/online/R3BCalifavsTofDOnlineSpectra.cxx	Updated method call from GetDetId() to GetPlaneId() and converted C-style arrays to std::vector
analysis/offline/R3BEventFilter.h	New event filter class header
analysis/offline/R3BEventFilter.cxx	New event filter class implementation
r3bdata/frsData/R3BFrsData.h	Changed header guard to #pragma once
analysis/offline/R3BIncomingBeta.h	Changed header guard to #pragma once
analysis/AnaLinkDef.h	Added R3BEventFilter to ROOT dictionary

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The deprecated GetHitId() method returns -1, but the return type is UInt_t (unsigned integer). This will cause -1 to be converted to a large unsigned value (typically 4294967295 on 32-bit systems). Consider either changing the return type to Int_t or returning 0 instead.

Suggested change

	[[deprecated]] UInt_t GetHitId() const { return -1; }
	[[deprecated]] UInt_t GetHitId() const { return 0; }

[Copilot]

Simplified return statement recommended. The if-else can be replaced with a direct return of the boolean expression.

Suggested change

	if (planes13ok || planes24ok)
	return true;
	else
	return false;
	}
	inline bool CheckFireConditionsAllPlanes(const std::vector<int>& v)
	{
	return planes13ok || planes24ok;
	}
	inline bool CheckFireConditionsAllPlanes(const std::vector<int>& v)
	{
	inline bool CheckFireConditionsAllPlanes(const std::vector<int>& v)
	{

[Copilot]

Potential null pointer dereference. The fHeader pointer is used without null checking on line 141. If fHeader is nullptr, this will cause a crash. Add a null check for fHeader before accessing GetExpId().

Suggested change

	if (!fHeader)
	{
	R3BLOG(error, "R3BEventFilter: Event header not available, skipping event");
	StoreEvent(false);
	return;
	}

[Copilot]

Missing null check after dynamic_cast. If the cast fails, frsdata will be nullptr and calling GetZ() or GetAq() on it will cause a crash. Add a null check after the dynamic_cast.

[Copilot]

Missing null check after dynamic_cast. If the cast fails, tofdhit will be nullptr and calling GetPlaneId() or GetChargeZ() on it will cause a crash. Add a null check after the dynamic_cast.

[Copilot]

Missing bounds check. The function accesses v[0], v[1], v[2], and v[3] without verifying that the vector has at least 4 elements. Add a size check similar to CheckFireConditionsAllPlanes to prevent out-of-bounds access.

[Copilot]

Typo in comment: "determinate" should be "determine".

Suggested change

	// Function to determinate the charge in terms of the limits
	// Function to determine the charge in terms of the limits

[Copilot]

Potential out-of-bounds access. The plane ID from GetPlaneId() is used to index into chargeSelected and fChargeLimits without validation. If plane is 0 or greater than 4, this will cause out-of-bounds access. Consider adding bounds checking to ensure plane is within the valid range (1-4) before using it as an array index.

[Copilot]

The lambda function isSelectedCharge accesses fChargeLimits[plane - 1] without validating that the index is within bounds. If plane is 0 or if fChargeLimits has fewer than 'plane' elements, this will cause undefined behavior. Add bounds checking before accessing the vector.

[Copilot]

Type mismatch: nHits is declared as UInt_t but the loop counter ihit on line 166 is Int_t. This can cause a signed/unsigned comparison warning. Consider making ihit also UInt_t or keeping nHits as Int_t for consistency with GetEntriesFast() which returns Int_t.

Suggested change

	UInt_t nHits = fHitItemsCalifa->GetEntriesFast();
	Int_t nHits = fHitItemsCalifa->GetEntriesFast();