Create a Fluid Flow API#74
Open
OroArmor wants to merge 22 commits intoQuiltMC:1.20from
Open
Conversation
OroArmor
added
new: library
LambdAurora
reviewed
Feb 14, 2022
# Conflicts: # settings.gradle
LambdAurora
suggested changes
Feb 24, 2022
Contributor
LambdAurora
left a comment
LambdAurora
left a comment
There was a problem hiding this comment.
I'm not sure if it's useful to get an event depending on the direction?
Especially if you iterate through every directions anyway.
Co-authored-by: LambdAurora <aurora42lambda@gmail.com>
Member
Author
|
Thats a good point, ill have the direction be a parameter |
EnnuiL
suggested changes
Jun 20, 2022
Contributor
EnnuiL
left a comment
EnnuiL
left a comment
There was a problem hiding this comment.
So far, the PR looks good; Just apply these tiny changes and all will be fine
OroArmor
commented
Jun 20, 2022
Co-authored-by: Ennui Langeweile <85590273+EnnuiL@users.noreply.github.com>
EnnuiL
approved these changes
Jun 23, 2022
Contributor
EnnuiL
left a comment
EnnuiL
left a comment
There was a problem hiding this comment.
I just realized that the onFlow event's parameter names might be a bit too verbose? but yeah, I can't think of any alternative shorter names that didn't sacrifice readability; Oh well
Here's the Ennui's Stamp of Approval
|
This needs to be updated to newest code + maybe can be made into an REA? |
Member
Author
|
This can't easily be made into a REA, but yeah I can update it. |
Member
Author
|
And by easily I mean it shouldn't. It's an event, not a property because there are too many variables |
EnnuiL
approved these changes
Aug 6, 2022
Contributor
EnnuiL
left a comment
EnnuiL
left a comment
There was a problem hiding this comment.
I still have no objections, however, here's a few nitpicks; Consider the general PR approved though
oliviathevampire
approved these changes
Aug 6, 2022
Co-authored-by: Ennui Langeweile <85590273+EnnuiL@users.noreply.github.com>
OroArmor
commented
Aug 6, 2022
…low/api/FluidFlowEvents.java
OroArmor
added
the
s: tested
Platymemo
reviewed
Oct 19, 2022
| * @param interactionBlock the block it interacts with | ||
| * @return an event if the conditions are met, otherwise {@code null} | ||
| */ | ||
| public static @Nullable Event<FluidFlowInteractionCallback> getEvent(Block flowingBlock, Block interactionBlock) { |
Contributor
There was a problem hiding this comment.
Do we have a standardization on whether @Nullable goes here or on the whole method declaration?
| return null; | ||
| } | ||
|
|
||
| public interface FluidFlowInteractionCallback { |
Contributor
There was a problem hiding this comment.
Suggested change
| public interface FluidFlowInteractionCallback { | |
| @FunctionalInterface | |
| public interface FluidFlowInteractionCallback { |
EnnuiL
added
s: outdated
# Conflicts: # settings.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This copies from https://github.com/FabricMC/fabric/pulls/1402, however, as I am the authors of said PRs, I allow my code to be added to QSL.
The testmod is a good example of how to add a new fluid flow event.
Questions to be asked:
Before this is merged, I would like to merge in a game test api to ensure vanilla behavior remains and to have a more effective test than currently having to go into a world to view the change.