Data driven models and animations#145
Open
OroArmor wants to merge 19 commits intoQuiltMC:1.20from
Open
Conversation
OroArmor
added
new: module
OroArmor
added
s: wip
Member
Author
|
@FoundationGames this PR uses code from JsonEM. On discord, you said it was fine for me to use the code. I am asking here for a more visible record. I still need to update the licenses for said files. |
Contributor
FoundationGames
left a comment
FoundationGames
left a comment
There was a problem hiding this comment.
I approve the merging of any code within this pull request that has been borrowed from JsonEM.
EnnuiL
reviewed
Aug 6, 2022
Platymemo
approved these changes
Sep 27, 2022
Contributor
Platymemo
left a comment
Platymemo
left a comment
There was a problem hiding this comment.
Lots of super little nitpicks but it looks great!
OroArmor
added
s: tested
EnnuiL
suggested changes
Sep 30, 2022
Contributor
EnnuiL
left a comment
EnnuiL
left a comment
There was a problem hiding this comment.
So far, so great! I only have style nitpicks for now, and I'd appreciate if you did a pass through the code with Checkstyle;
Considering the majorness of this PR, I'll want to experiment with it on practice later
Co-authored-by: Ennui Langeweile <85590273+EnnuiL@users.noreply.github.com>
EnnuiL
suggested changes
Jan 2, 2023
Contributor
EnnuiL
left a comment
EnnuiL
left a comment
There was a problem hiding this comment.
CI's broken due to missing headers; Fix CI, and I'll re-review again :P
…braries into data-driven-models
Member
Author
|
Note. This pr will break geckolib, so maybe we should figure something out before killing that mod |
EnnuiL
suggested changes
Jun 8, 2023
Contributor
EnnuiL
left a comment
EnnuiL
left a comment
There was a problem hiding this comment.
This PR now makes more sense to me!
Contributor
There was a problem hiding this comment.
You'll need to copy the icon again! I had ran oxipng through everything :p
|
|
||
| @Invoker("<init>") | ||
| static ModelCuboidData create(@Nullable String string, float f, float g, float h, float i, float j, float k, float l, float m, Dilation dilation, boolean bl, float n, float o, Set<Direction> directions) { | ||
| throw new AssertionError("Mixin injection failed."); |
Contributor
There was a problem hiding this comment.
Suggested change
| throw new AssertionError("Mixin injection failed."); | |
| throw new IllegalStateException("Mixin injection failed."); |
| Set<Direction> directions(); | ||
|
|
||
| @Invoker("<init>") | ||
| static ModelCuboidData create(@Nullable String string, float f, float g, float h, float i, float j, float k, float l, float m, Dilation dilation, boolean bl, float n, float o, Set<Direction> directions) { |
Contributor
There was a problem hiding this comment.
I do wonder if this method has arg names now
Comment on lines
+28
to
+29
| public record AnimationType(Codec<Animation> codec) { | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| public record AnimationType(Codec<Animation> codec) { | |
| } | |
| public record AnimationType(Codec<Animation> codec) {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
Don't use regex for model layer parsing