feat(tile): optimize tile map updates and rendering #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalohaki
commented
Sep 30, 2025
rafalohaki
commented
- Add updateRequested flag to gate heavy update work
- Implement computeUpdateRegionLimit to dynamically limit update regions
- Replace direct draw calls with requestUpdate where appropriate
- Fix getVisibleTiles to return actual visible regions count
- Add bin/ to gitignore for build artifacts
- Add updateRequested flag to gate heavy update work - Implement computeUpdateRegionLimit to dynamically limit update regions - Replace direct draw calls with requestUpdate where appropriate - Fix getVisibleTiles to return actual visible regions count - Add bin/ to gitignore for build artifacts
Introduce IScriptArea interface and FallbackScriptArea implementation to provide a graceful fallback when RichTextFX is unavailable or incompatible. Modify CodeEditor to dynamically choose between GroovyCodeArea and FallbackScriptArea based on runtime compatibility. Also update .gitignore to exclude notes directory.
…verlay Dynamically set thread counts for parseExecutor and overlayCacheLoaders based on available processors and global process threads configuration to improve resource utilization and performance
- Replace ImageIO with pngj for faster PNG saving with lower compression - Implement batch writes for overlay cache to reduce LevelDB I/O overhead - Tune LevelDB options for better overlay cache performance - Use virtual threads for I/O-bound overlay cache loading - Add proper synchronization for task draining in JobHandler - Improve concurrency configuration for parser threads - Add missing default cases in switch statements
Clean up code by removing unused imports to improve code maintainability and reduce clutter
…heck Fix the scaling logic for corrupted chunk overlay by using proper nearest-neighbor downscaling. Also add null check for waterHeights array to prevent potential NPE.
- Upgrade Gradle wrapper to version 9.1.0 for latest features and improvements - Add Guava library (v33.4.8-jre) as a new dependency for utility functions - Configure Gradle Versions Plugin to reject unstable dependency candidates
refactor(cli): replace deprecated HelpFormatter with builder pattern
- Use assignment operator for group property - Standardize maven repository URL syntax with assignment operators - Improve indentation consistency in repositories block
Querz
reviewed
Oct 4, 2025
| } else if (regionFile.exists()) { | ||
| if (cacheImage.exists()) { | ||
| // load cached image asynchronously to keep UI responsive | ||
| image = new Image(cacheImage.toURI().toString(), true); |
Owner
There was a problem hiding this comment.
This may cause Image#getPixelReader() to return null, because it checks if the image is fully loaded and returns null if its progress is < 1.0 (see JavaDoc of getPixelReader())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.