Deserialize device in events only if there is a handler registered#402
Deserialize device in events only if there is a handler registered#402marmarek merged 1 commit intoQubesOS:mainfrom
Conversation
Deserializing device parameter may trigger a call to get remaining details. Don't do that if there are no handlers for such event anyway. Specifically, this avoids calling admin.vm.device.usb.Available (and others) by sys-audio whenever new device is plugged in.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
=======================================
Coverage 76.10% 76.11%
=======================================
Files 53 53
Lines 9287 9289 +2
=======================================
+ Hits 7068 7070 +2
Misses 2219 2219 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025122104-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025111104-4.3&flavor=update
Failed tests57 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/158999#dependencies 14 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:32 performance degradations
Remaining performance tests:119 tests
|
Deserializing device parameter may trigger a call to get remaining
details. Don't do that if there are no handlers for such event anyway.
Specifically, this avoids calling admin.vm.device.usb.Available (and
others) by sys-audio whenever new device is plugged in.