Generalize GaussianLinearCombination to operators#104
Open
arnavk23 wants to merge 2 commits intoQuantumSavory:mainfrom
Open
Generalize GaussianLinearCombination to operators#104arnavk23 wants to merge 2 commits intoQuantumSavory:mainfrom
arnavk23 wants to merge 2 commits intoQuantumSavory:mainfrom
Conversation
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
=======================================
Coverage ? 96.16%
=======================================
Files ? 19
Lines ? 2709
Branches ? 0
=======================================
Hits ? 2605
Misses ? 104
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@apkille whenever you are free, Andrew please take a look. Thanks! |
Member
|
Thanks for the PR @arnavk23! And sorry for the slow response, I've been quite busy these past few months. I will do my best to review later this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #83 by generalizing GaussianLinearCombination to support homogeneous linear combinations of GaussianState, GaussianUnitary, or GaussianChannel (with consistent basis and ħ).
It adds operator/channel arithmetic support (scalar ops and +/- with matching LC types), while keeping state-specific functionality and backward compatibility intact.