Add test suite for backwards compatibility#999
Open
Jan Tilly (jtilly) wants to merge 2 commits intomainfrom
Open
Add test suite for backwards compatibility#999Jan Tilly (jtilly) wants to merge 2 commits intomainfrom
Jan Tilly (jtilly) wants to merge 2 commits intomainfrom
Conversation
Member
|
I like what this PR is doing, but I wonder if we need to create a dozen pixi environments every time. My understanding is that we want to ensure we are able to predict from an old model. Why not fit once and store the pickle file in git, then check in the current environment if we are able to load it. |
Member
|
Also, FYI for others that wants to test this locally. Older versions of pixi won't work. You need to update pixi (I had 0.63 and it didn't work). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm adding a test suite to ensure that we remain backwards compatible in the sense that we can still predict from models that were fitted using an old version of glum.
Fits a GLM with each released minor version of glum (discovered dynamically via
pixi search), pickles the model, then unpickles it under the current version and checks that predictions match.Three new files under
tests/backwards_compatibility/:fit.py— fits and saves a model + predictions; accepts a version label orHEADrun.py— orchestratesfit.pyacross all versions and compares predictions against HEADRuns on PRs via a GitHub Actions workflow. Also available as
pixi run test-backwards-compatibility.