-
Notifications
You must be signed in to change notification settings - Fork 562
Solution Pool #3657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution Pool #3657
Conversation
Reordering and documenting API
Use the Pyomo Bunch class as an alias for Munch, to avoid introducing an additional Pyomo dependency.
|
Note that this PR now includes updates to the Bunch class defined in pyomo.common. I have been using the public Munch class, but these revisions align the Bunch API with Munch. |
Avoiding use of KW_ONLY, which is an internal mechanism
Using new serialization API, which is simpler. :)
1. Reworking solver matrix logic 2. Fixing test to benchmark against the solution values
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3657 +/- ##
==========================================
- Coverage 89.40% 89.32% -0.09%
==========================================
Files 909 910 +1
Lines 105541 105935 +394
==========================================
+ Hits 94364 94631 +267
- Misses 11177 11304 +127
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Added non-positive error check and value 1 warning for num_solutions in balas
Added num_solution error if num_solutions is non-positive, warning if num_solutions =1
1. Renaming kwds to kwargs to clarify the intent to capture all keyword arguments. 2. Refactoring PyomoSolution into a class that inherits from Solution.
This supported compatibility with Munch, but this isn't being used.
|
It's not obvious to me why the linux slim tests are failing. Do we need to conditionally import numpy? |
@whart222 yes, numpy needs to be treated as an optional dependency so tests relying on numpy need to be skipped when it's not available. |
skipif needs to come *after* the parameterize decorator
|
@whart222 - Should this PR be closed, given the followup to our discussion last month? |
Fixes N/A (partially addresses #3513) .
Summary/Motivation:
The alternative_solutions contrib package includes a rudimentary solution pool object. This PR includes a more comprehensive capability for defining and managing solution pools.
Changes proposed in this PR:
NOTE: This is a WIP PR. I'm submitting this now to help define expectations for finalizing this new capability.
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: