feat: General enhancements for views#3093
Open
NeloBlivion wants to merge 149 commits intoPycord-Development:masterfrom
Open
feat: General enhancements for views#3093NeloBlivion wants to merge 149 commits intoPycord-Development:masterfrom
NeloBlivion wants to merge 149 commits intoPycord-Development:masterfrom
Conversation
* fix(actions): rework release workflow * style(pre-commit): auto fixes from pre-commit.com hooks --------- Co-Authored-By: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Lala Sabathil <lala@pycord.dev>
Lumabots
previously approved these changes
Mar 25, 2026
Contributor
Lumabots
left a comment
Lumabots
left a comment
There was a problem hiding this comment.
lgtm, tested on my bot for weeks and no issue to declare
Paillat-dev
requested changes
Mar 25, 2026
| for item in custom_view.children: | ||
| self.add_item(item) | ||
|
|
||
| def clear_items(self) -> Self: |
Member
There was a problem hiding this comment.
So not sure this is necessary after my other fix but doesn't hurt to keep it in tbh.
Member
Author
There was a problem hiding this comment.
if there have been no issues with your fix, it may be better for me to revert this
Member
There was a problem hiding this comment.
Up to you to decide what is better. I'll double check that the issue is still fixed too later
Paillat-dev
reviewed
Mar 25, 2026
Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: Nelo <41271523+NeloBlivion@users.noreply.github.com>
Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: Nelo <41271523+NeloBlivion@users.noreply.github.com>
Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: Nelo <41271523+NeloBlivion@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replace_itemadded toDesignerView,ActionRow,Section,Container, andMediaGalleryadd_itemsupports positioning with parametersbefore,after, andindexget_itemsupports getting items by any attribute instead of justidandcustom_idMessage.get_viewto retrieve a stored view or generate a new viewlen(View)to get the true item count in a viewadd_xvariants on DesignerViewadd_textandadd_labelon DesignerModalDesignerModal.from_dictread,save, andto_filetoUnfurledMediaItemInformation
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.