Fix hardcoded obsidian check when igniting a portal#1750
Merged
granny merged 1 commit intoPurpurMC:ver/1.21.11from Jan 8, 2026
Merged
Fix hardcoded obsidian check when igniting a portal#1750granny merged 1 commit intoPurpurMC:ver/1.21.11from
granny merged 1 commit intoPurpurMC:ver/1.21.11from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseFireBlock.isPortal currently has a hardcoded check for a neighbouring Obsidian block, which prevents portals including Crying Obsidian from being ignited if the targeted block has no neighbouring Obsidian.
This PR replaces the check with testing against PortalShape.FRAME which respects the Crying Obsidian setting.
Before:
https://github.com/user-attachments/assets/fa2083be-35aa-484c-afca-814483aa1de2
After:
https://github.com/user-attachments/assets/94069a85-d332-4c1d-831c-8b67b1f18b92