apply tunnel parameters on reload - #2489
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tunnel parameters are taken when the destination is made, so a reload never
changed them: FindLocalDestination hands back the running destination and the
options read from the section were dropped on the floor.
Reconfigure is already there and used by I2CP, so the reload calls it. The pool
takes the new numbers as it is, without being torn down: it builds the tunnels
it lacks and lets the extra ones expire. A destination shared by several
tunnels is left alone, only the section that owns it can change it.
Checked on a live router: with inbound and outbound quantity raised from 3 to 8
a reload took the destination from 6 tunnels to 10 within 150 seconds and it
kept climbing, connections through the tunnel stayed alive, and a reload with
an unchanged config leaves everything as it was.