don't put leading comma in ClientServicesInfo reply - #2485
Merged
Conversation
Contributor
|
По сути чинит ситуацию, когда первый аргумент не проходит правило А всё остальное тож самое. Вероятность такого, вообще чем могло быть вызвано |
Contributor
|
кк |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comma was written by iterator position, not by what has already been put
into the reply. Token is a required parameter of every request, so a client
that sends it before the service name gets a reply starting with a comma:
which is not valid JSON. RouterInfoHandler right above does it with a flag,
this makes ClientServicesInfo do the same.