Skip to content

don't put leading comma in ClientServicesInfo reply - #2485

Merged
orignal merged 1 commit into
PurpleI2P:opensslfrom
pobregat0:i2pcontrol-services-comma
Aug 17, 2026
Merged

don't put leading comma in ClientServicesInfo reply#2485
orignal merged 1 commit into
PurpleI2P:opensslfrom
pobregat0:i2pcontrol-services-comma

Conversation

@pobregat0

Copy link
Copy Markdown
Contributor

The comma was written by iterator position, not by what has already been put
into the reply. Token is a required parameter of every request, so a client
that sends it before the service name gets a reply starting with a comma:

{"id":2,"result":{,"I2PTunnel":{"client":{...

which is not valid JSON. RouterInfoHandler right above does it with a flag,
this makes ClientServicesInfo do the same.

@wipedlifepotato

Copy link
Copy Markdown
Contributor

По сути чинит ситуацию, когда первый аргумент не проходит правило

		auto it1 = m_ClientServicesInfoHandlers.find (it->first);
		if (it1 != m_ClientServicesInfoHandlers.end ())

А всё остальное тож самое. Вероятность такого, вообще чем могло быть вызвано

@wipedlifepotato

Copy link
Copy Markdown
Contributor

кк

@orignal
orignal merged commit 73ee29a into PurpleI2P:openssl Aug 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants