Initilize cec_adapter_descriptor when detecting adapters #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has now been marked as stale because there hasn't been any activity for 90 days. Please check if this pull request is still relevant when using the latest version of libCEC and remove the stale label or add a comment to reset the stale state. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
CLibCEC::DetectAdapters()withbQuickscan = true, not all fields of the returned structs are initilized. This is indirectly documented: "Firmware version information and the exact device type will be missing". However, I think it's unsound and error prone when a library returns only partially initilized structs. This change won't hurt, though.