Open
Conversation
muniled.py
Outdated
Member
There was a problem hiding this comment.
It would be better to keep the network handling in the get_prediction method. Move the try logic around urlopen in get_predictions. This will insulate downstream processes from potential errors.
Member
|
Comments inline. Good idea to pass handle the url exceptions. How about slowly dimming the lights the longer its been without an update? |
ghost
assigned
Member
Author
|
Moved stuff to get_prediction. Added a placeholder for a future dim method |
Member
Author
|
I apparently managed to hit close instead of comment... |
Member
Author
|
Totally digging the pedanticism. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bryanculbertson does this make sense? Whenever the network request would fail it would kill the whole shebang. Now if it fails it will just try again in 5 seconds. Might need to set some indicator (maybe change the color of the station leds or blink something) to indicate when data is stale in the event that the network goes down.