Skip to content

Allow non-existent options to be monitored.#32

Merged
jdevalk merged 1 commit intoProgressPlanner:developfrom
bradyvercher:fix/non-existent-options
Apr 1, 2025
Merged

Allow non-existent options to be monitored.#32
jdevalk merged 1 commit intoProgressPlanner:developfrom
bradyvercher:fix/non-existent-options

Conversation

@bradyvercher
Copy link
Copy Markdown
Contributor

Context

This fixes the monitoring of non-existent options. WordPress triggers a different filter when an option doesn't exist. The same filter is used again on lines 217 and 230.

Very cool plugin! I was about to build something very similar before I stumbled on this.

Summary

This PR can be summarized in the following changelog entry:

  • Fix monitoring of non-existent options.

Relevant technical choices:

  • str_starts_with() is a little easier to read, but is PHP 8+ if that's relevant.

Test instructions

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities.
  • I have added unit tests to verify the code works as intended.
  • I have checked that the base branch is correctly set.

Fixes #

@aristath aristath requested a review from jdevalk April 1, 2025 10:13
@jdevalk jdevalk merged commit 8826444 into ProgressPlanner:develop Apr 1, 2025
6 of 7 checks passed
@jdevalk
Copy link
Copy Markdown
Member

jdevalk commented Apr 1, 2025

Thanks @bradyvercher !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants