Fix crash in digging plugin death handler (#3553)#3835
Open
plainprince wants to merge 1 commit intoPrismarineJS:masterfrom
Open
Fix crash in digging plugin death handler (#3553)#3835plainprince wants to merge 1 commit intoPrismarineJS:masterfrom
plainprince wants to merge 1 commit intoPrismarineJS:masterfrom
Conversation
When the bot dies during certain states (e.g. Velocity proxy transfers, or when using Bun runtime), the EventEmitter internals can be torn down before the death event fires. This causes removeAllListeners to throw "TypeError: undefined is not an object (evaluating 'this._events')". Wrapping the death handler in a try/catch prevents the crash. Fixes PrismarineJS#3553 Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
We should fix the root cause not ignore the problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deathevent handler inlib/plugins/digging.jswith a try/catch to prevent a crash whenbot._eventsis undefined during the death event.Fixes #3553
Error
Test plan
Made with Cursor