Bump @types/node to 25.2.1 + fix flaky time & nether tests

package.json

@@ -41,7 +41,7 @@
     "vec3": "^0.1.7"
   },
   "devDependencies": {
-    "@types/node": "^24.0.6",
+    "@types/node": "^25.2.1",
     "doctoc": "^2.0.1",
     "minecraft-wrap": "^1.3.0",
     "mineflayer": "file:",

test/externalTests/nether.js

@@ -1,6 +1,6 @@
 const assert = require('assert')
 const Vec3 = require('vec3')
-const { once } = require('../../lib/promise_utils')
+const { once, sleep } = require('../../lib/promise_utils')
 
 module.exports = () => async (bot) => {
   // Test spawn event on death
@@ -46,7 +46,14 @@ module.exports = () => async (bot) => {
   await once(bot, 'forcedMove')
   await bot.waitForChunksToLoad()
 
-  const lowerBlock = bot.blockAt(bot.entity.position.offset(0, -1, 0))
+  // Poll until the block below is loaded and non-air before placing.
+  // On slow CI, chunks may report as loaded before block data is ready.
+  let lowerBlock = bot.blockAt(bot.entity.position.offset(0, -1, 0))
+  while (!lowerBlock || lowerBlock.name === 'air') {
+    await sleep(100)
+    lowerBlock = bot.blockAt(bot.entity.position.offset(0, -1, 0))
+  }
+
   await bot.lookAt(lowerBlock.position, true)
   await bot.test.setInventorySlot(36, new Item(signItem.id, 1, 0))
   await bot.placeBlock(lowerBlock, new Vec3(0, 1, 0))

test/externalTests/plugins/testCommon.js

@@ -4,9 +4,9 @@ const { spawn } = require('child_process')
 const { once } = require('../../../lib/promise_utils')
 const process = require('process')
 const assert = require('assert')
-const { sleep, onceWithCleanup, withTimeout } = require('../../../lib/promise_utils')
+const { sleep, onceWithCleanup } = require('../../../lib/promise_utils')
 
-const timeout = 5000
+const timeout = 20000
 module.exports = inject
 
 function inject (bot) {
@@ -188,14 +188,21 @@ function inject (bot) {
 
     const detectChildJoin = async () => {
       const [message] = await onceWithCleanup(bot, 'message', {
-        timeout,
         checkCondition: message => message.json.translate === 'multiplayer.player.joined'
       })
       childBotName = message.json.with[0].insertion
       bot.chat(`/tp ${childBotName} 50 ${bot.test.groundY} 0`)
-      setTimeout(() => {
-        bot.chat('loaded')
-      }, 5000)
+      // Wait for the child entity to arrive at the teleport target,
+      // confirming the server has processed the TP
+      const targetPos = new Vec3(50, bot.test.groundY, 0)
+      while (!bot.players[childBotName]?.entity ||
+             bot.players[childBotName].entity.position.distanceTo(targetPos) > 5) {
+        await sleep(100)
+      }
+      // Let the child's physics engine initialize at the new position
+      // (ground detection, chunk processing) before starting the test
+      await bot.waitForTicks(60)
+      bot.chat('loaded')
     }
 
     const runExampleOnReady = async () => {
@@ -216,7 +223,7 @@ function inject (bot) {
 
       try {
         process.kill(child.pid, 'SIGTERM')
-        const [code] = await onceWithCleanup(child, 'close', { timeout: 1000 })
+        const [code] = await onceWithCleanup(child, 'close', { timeout: 5000 })
         console.log('close requested', code)
       } catch (e) {
         console.log(e)
@@ -228,8 +235,11 @@ function inject (bot) {
       }
     }
 
+    // Let mocha's test-level timeout (90s) be the backstop instead of
+    // an inner withTimeout, which was causing premature failures on
+    // slow CI runners.
     try {
-      await withTimeout(Promise.all([detectChildJoin(), runExampleOnReady()]), 30000)
+      await Promise.all([detectChildJoin(), runExampleOnReady()])
     } catch (err) {
       console.log(err)
       return closeExample(err)

test/externalTests/time.js

@@ -43,6 +43,21 @@ module.exports = () => async (bot) => {
     }
   }
 
+  // Helper to set gamerule using the correct name for the version
+  const setDaylightCycle = (value) => {
+    if (bot.supportFeature('gameRuleUsesResourceLocation')) {
+      bot.test.sayEverywhere(`/gamerule minecraft:advance_time ${value}`)
+    } else {
+      bot.test.sayEverywhere(`/gamerule doDaylightCycle ${value}`)
+    }
+  }
+
+  // Disable daylight cycle before time transition tests to prevent
+  // time from drifting between /time set and the assertion
+  const originalDaylightCycle = bot.time.doDaylightCycle
+  setDaylightCycle(false)
+  await waitForTime()
+
   // Test time transitions
   const timeTests = [
     { time: 18000, name: 'midnight', isDay: false },
@@ -58,6 +73,10 @@ module.exports = () => async (bot) => {
     assert.strictEqual(bot.time.isDay, test.isDay, `${test.name} should be ${test.isDay ? 'day' : 'night'}`)
   }
 
+  // Re-enable daylight cycle for progression test
+  setDaylightCycle(true)
+  await waitForTime()
+
   // Test day and moon phase progression
   const currentDay = bot.time.day
   const currentPhase = bot.time.moonPhase
@@ -66,24 +85,19 @@ module.exports = () => async (bot) => {
   assert(bot.time.day >= currentDay + 1, `Expected day to be at least ${currentDay + 1}, got ${bot.time.day}`)
   assert.notStrictEqual(bot.time.moonPhase, currentPhase, 'Moon phase should change after a full day')
 
-  // Test daylight cycle
-  const originalDaylightCycle = bot.time.doDaylightCycle
-  if (bot.supportFeature('gameRuleUsesResourceLocation')) {
-    bot.test.sayEverywhere('/gamerule minecraft:advance_time false')
-  } else {
-    bot.test.sayEverywhere('/gamerule doDaylightCycle false')
-  }
+  // Test daylight cycle toggle
+  setDaylightCycle(false)
   await waitForTime()
   assert.strictEqual(bot.time.doDaylightCycle, false)
 
-  if (bot.supportFeature('gameRuleUsesResourceLocation')) {
-    bot.test.sayEverywhere(`/gamerule minecraft:advance_time ${originalDaylightCycle}`)
-  } else {
-    bot.test.sayEverywhere(`/gamerule doDaylightCycle ${originalDaylightCycle}`)
-  }
+  setDaylightCycle(originalDaylightCycle)
   await waitForTime()
   assert.strictEqual(bot.time.doDaylightCycle, originalDaylightCycle)
 
+  // Disable daylight cycle again for day/night range tests
+  setDaylightCycle(false)
+  await waitForTime()
+
   // Test day/night transitions
   const dayNightTests = [
     { command: 'day', range: [0, 12000], isDay: true },
@@ -96,4 +110,8 @@ module.exports = () => async (bot) => {
     assert(isTimeInRange(bot.time.timeOfDay, test.range[0], test.range[1]), `Time should be in ${test.command} range`)
     assert.strictEqual(bot.time.isDay, test.isDay, `${test.command} should be ${test.isDay ? 'day' : 'night'}`)
   }
+
+  // Restore original daylight cycle setting
+  setDaylightCycle(originalDaylightCycle)
+  await waitForTime()
 }