Bump @types/node from 24.10.11 to 25.2.1#3821
Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
Closed
Conversation
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 24.10.11 to 25.2.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 25.2.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
plainprince
pushed a commit
to plainprince/mineflayer
that referenced
this pull request
Feb 8, 2026
- time: Disable daylight cycle before time transition tests to prevent time from drifting between /time set and the assertion (e.g. expected 18000, got 21695). Re-enable only for progression and toggle tests. - nether: Add 1s wait after chunk loading to give slow CI environments time to stabilize before block placement. These flaky tests were causing spurious CI failures on unrelated PRs (e.g. PrismarineJS#3821). Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
Contributor
|
The CI failures here are not caused by this PR -- they're pre-existing flaky tests:
Opened #3827 to fix both. Once that's merged, this PR should pass cleanly. |
plainprince
pushed a commit
to plainprince/mineflayer
that referenced
this pull request
Feb 8, 2026
Bump @types/node to ^25.2.1 (from PrismarineJS#3821) and fix two flaky tests that were causing spurious CI failures: - time: disable daylight cycle during /time set assertions to prevent drift (e.g. expected 18000, got 21695) - nether: add stabilization wait after chunk loading on slow CI Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
Contributor
Contributor
Contributor
Author
|
Superseded by #3829. |
plainprince
pushed a commit
to plainprince/mineflayer
that referenced
this pull request
Feb 14, 2026
Bump @types/node to ^25.2.1 (from PrismarineJS#3821) and fix two flaky tests that were causing spurious CI failures: - time: disable daylight cycle during /time set assertions to prevent drift (e.g. expected 18000, got 21695) - nether: add stabilization wait after chunk loading on slow CI Co-authored-by: Cursor <cursoragent@cursor.com>
rom1504
pushed a commit
that referenced
this pull request
Feb 15, 2026
* Bump @types/node from 24.0.6 to 25.2.1 and fix flaky tests Bump @types/node to ^25.2.1 (from #3821) and fix two flaky tests that were causing spurious CI failures: - time: disable daylight cycle during /time set assertions to prevent drift (e.g. expected 18000, got 21695) - nether: add stabilization wait after chunk loading on slow CI Co-authored-by: Cursor <cursoragent@cursor.com> * Increase runExample timeout from 30s to 60s The 30s timeout for example tests covers child process spawn, server join, 5s stabilization wait, chunk loading, and the actual test. On slow CI runners this was too tight, causing spurious timeouts (e.g. exampleBee on 1.19.3). Co-authored-by: Cursor <cursoragent@cursor.com> * Replace timeout-based test fixes with robust alternatives nether: Replace blind 1s wait with polling loop that checks for a solid block below before placing. Mocha's 90s test timeout is the backstop. runExample: Remove withTimeout wrapper (mocha handles overall timeout), remove 5s setTimeout before saying "loaded" (server command ordering guarantees the TP is applied before the chat message reaches the child), remove timeout from child join detection. This eliminates the premature "Promise timed out" failures on slow CI. testCommon: Increase base onceWithCleanup timeout from 5s to 20s for helper functions (gamemode change, teleport, clear inventory, etc.) to prevent spurious failures on slow CI while still providing useful error messages. Co-authored-by: Cursor <cursoragent@cursor.com> * Fix runExample: wait for child entity + physics settling The child bot's physics engine needs time to initialize at the teleported position (ground detection, etc.) before tests that require jumping (exampleDigger build) can work. Replace the removed blind 5s setTimeout with: 1. Condition-based poll for child entity at the TP target position 2. waitForTicks(60) for physics engine to settle (~3s game time) This is more robust than the original setTimeout because the entity check adapts to server speed and waitForTicks is tied to game ticks. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Simeon Kummer <simeon@hitthecode.de> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @types/node from 24.10.11 to 25.2.1.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)