Send client brand correctly during configuration state for MC 1.20.2+#3794
Open
ODAKAB wants to merge 1 commit intoPrismarineJS:masterfrom
Open
Send client brand correctly during configuration state for MC 1.20.2+#3794ODAKAB wants to merge 1 commit intoPrismarineJS:masterfrom
ODAKAB wants to merge 1 commit intoPrismarineJS:masterfrom
Conversation
Member
|
This looks like it belongs in node-minecraft-protocol |
Author
I don't know, based on rest of the code and also based on how it handled sending client brand inside mineflayer, it made sense to me. If you say past commits were also inappropriate to do them inside mineflayer, then it might be better if someone more familiar with all these projects and their relationship does it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handling configuration state should be considered with #3786